Keep service credentials out of public ROS parameters - #775
Draft
axelpey wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public simulator launches UniNavid with
INNATE_SERVICE_KEY, then exposes that value as the ROSservice_keyparameter. A visitor can request/uninavid_node/get_parametersthrough the public/wsbridge. The same credential parameter pattern exists in the logger and training nodes.Credentials now come directly from the local environment and are never declared as ROS parameters. The unused UniNavid
/brain/backend_configcredential subscription is removed as well, since anything sent on ROS is readable by bridge clients. Owner authentication and navigation configuration continue to use the existing environment; key changes require a node restart. Documentation is updated for the removed parameter/topic inputs.Validation: reproduced baseline disclosure with a synthetic key through the actual aiohttp
/wsfront door, real RWS server and real UniNavid node inside a dedicated networkless ROS container. After the fix, credential reads return no value while normalforward_speedreads work; two hardened integration tests pass. No provider requests or robot motion. Live checks only listed parameter names on both simulator deployments; no live credential value was retrieved.This draft is the smallest independent mitigation for the confirmed ROS disclosure. It does not remove keys from process environments or close separate file/provider-error paths; those are covered by paired follow-up drafts. Production remains unchanged until an approved image is released and old sessions are retired. Do not merge or mark ready without Axel's approval.